Fixes error in case of non-default column name #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod `length' for nil:NilClass
chillicoder
added a commit
to chillicoder/flag_shih_tzu
that referenced
this pull request
Jul 17, 2012
|
The purpose for storing column name in flag_options[colmn][:column] is to allow for multiple flag columns on a single table. It is in use, and can't really be removed. Will need to figure out a workaround for the bug you describe. |
|
I think I may have misunderstood what you meant, and I will look into this further. |
|
I figured out what you meant. Just needed to look at the code for a bit. Merged @ b047b59 ! Thanks :) |
|
Released in 0.3.4 (0.3.3 got skipped due to a credentials issue with RubyGems.org) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"error undefined method `length' for nil:NilClass"
In case of default :flag_query_mode (:in_list) and non-default :column options,
flag_options[colmn][:column] is a symbol, but flag_mapping has string keys.
Storing column name in flag_options[colmn][:column] is unuseful and it is duplication of colmn.