Fixes error in case of non-default column name #20

Merged
merged 1 commit into from Jun 20, 2013

Conversation

Projects
None yet
2 participants
Contributor

artemas commented Jul 10, 2012

"error undefined method `length' for nil:NilClass"
In case of default :flag_query_mode (:in_list) and non-default :column options,
flag_options[colmn][:column] is a symbol, but flag_mapping has string keys.
Storing column name in flag_options[colmn][:column] is unuseful and it is duplication of colmn.

@chillicoder chillicoder added a commit to chillicoder/flag_shih_tzu that referenced this pull request Jul 17, 2012

@chillicoder chillicoder from Pull Request #20 in original repo 9c38f6d
Owner

pboling commented Nov 6, 2012

The purpose for storing column name in flag_options[colmn][:column] is to allow for multiple flag columns on a single table. It is in use, and can't really be removed. Will need to figure out a workaround for the bug you describe.

pboling closed this Nov 6, 2012

Owner

pboling commented Nov 13, 2012

I think I may have misunderstood what you meant, and I will look into this further.

pboling reopened this Nov 13, 2012

@pboling pboling merged commit f9eaa6c into pboling:master Jun 20, 2013

1 check passed

default The Travis build passed
Details
Owner

pboling commented Jun 20, 2013

I figured out what you meant. Just needed to look at the code for a bit. Merged @ b047b59 ! Thanks :)

Owner

pboling commented Jun 21, 2013

Released in 0.3.4 (0.3.3 got skipped due to a credentials issue with RubyGems.org)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment