Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.archive file should have macros expanded #82

Closed
klauer opened this issue Mar 17, 2022 · 2 comments
Closed

.archive file should have macros expanded #82

klauer opened this issue Mar 17, 2022 · 2 comments

Comments

@klauer
Copy link
Contributor

klauer commented Mar 17, 2022

In my btps IOC, there is the following line:
$(BTPS):DEST:07:SRC:04:FFCenterY:InRange_RBV.VAL 1 scan
Which will not work appropriately with the archiver.
This should be expanded with DB_PARAMETERS from the Makefile.

@klauer
Copy link
Contributor Author

klauer commented Mar 17, 2022

Fixed this locally in that IOC by way of:

all: build paths clean fix_archive_file

fix_archive_file:
        msi -M $(DB_PARAMETERS),IOC=ioc-las-bts \
                $(ARCHIVE_PATH)/las_bts.db.archive > $(ARCHIVE_PATH)/.las_bts.db.archive
        install -p -m 0444 $(ARCHIVE_PATH)/.las_bts.db.archive $(ARCHIVE_PATH)/las_bts.db.archive

This should be upstreamed

@klauer
Copy link
Contributor Author

klauer commented Aug 11, 2022

These are now generated dynamically in the IOC; I think the .archive file in this issue is generated by pytmc, which cannot know about the macros defined in Makefile.

That probably means what pytmc can generate is a .archive.template and not a .archive file, really.

Closing this as invalid-ish.

@klauer klauer closed this as completed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant