Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: IOCNAME -> IOC #58

Merged
merged 2 commits into from
Jun 23, 2020
Merged

FIX: IOCNAME -> IOC #58

merged 2 commits into from
Jun 23, 2020

Conversation

klauer
Copy link
Contributor

@klauer klauer commented Jun 23, 2020

Questionably includes back-compatibility for "IOCNAME" macro when including database files.

If we can confirm no one is using this, it should be removed.

Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

It may be time to make a registry of all of our ads-ioc iocs... to check in on all of the potential Makefile edits.

@klauer
Copy link
Contributor Author

klauer commented Jun 23, 2020

Good idea. Is there any easy way to query IOCs which rely on a certain binary with command-line tools?

@ZLLentz
Copy link
Member

ZLLentz commented Jun 23, 2020

I didn't find exactly that, but there is a file: .../iocData/${IOC}/iocInfo/IOC.epicsEnvShow that contains all environment variables, including something like:

TOP=/reg/g/pcds/epics/ioc/common/ads-ioc/R0.2.5

Seems appropriate for a quick grep/regex bash script

@klauer
Copy link
Contributor Author

klauer commented Jun 23, 2020

Nice! That'll do.

@klauer klauer merged commit bf58dac into pcdshub:master Jun 23, 2020
@ZLLentz
Copy link
Member

ZLLentz commented Jun 23, 2020

I suspect you could also use the IOCs configured in iocmanager, grab the top lines of their st.cmd files and check for the binary

@klauer klauer deleted the fix_iocname branch June 23, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants