-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XML reformatter sometimes requires multiple tries #19
Comments
Here's of one example of a diff that only includes changes made on the second try, as maybe a clue:
I personally can't figure out what's different yet |
After a closer inspection, there is a single space after in these three multiline comment blocks after the first reformat, but not after the second. |
I have two suggestions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
This hook: https://github.com/pcdshub/pre-commit-hooks/blob/master/pre_commit_hooks/xml_format.py#L1
sometimes requires multiple tries to properly reformat:
We should double-check the code - potentially reformatting with multiple iterations or increasing some parameter to the existing call to dive deeper into the XML.
The text was updated successfully, but these errors were encountered: