Problem with cmor close deallocating forcings in the MIP tables

[jkettleb]

I think there is a problem in cmor close - I started seeing seg faults at the end of last week, which I think I've tracked down to a piece of code for deallocating the forcings in the MIP tables.

Here's a patch:

--- a/Src/cmor.c
+++ b/Src/cmor.c
@@ -3917,8 +3917,8 @@ int cmor_close(void)
}
if (cmor_tables[i].nforcings>0) {
for (j=0;j<cmor_tables[i].nforcings;j++) {

•   free(cmor_tables[i].forcings[i]);
  

•   cmor_tables[i].forcings[i]=NULL;
  

•   free(cmor_tables[i].forcings[j]);
  

•   cmor_tables[i].forcings[j]=NULL;
  

  }
  free(cmor_tables[i].forcings);
  cmor_tables[i].forcings=NULL;

Could you check you agree with the patch and make the appropriate changes in the repository?

[doutriaux1]

patch is already in devel (you submitted it a while ago). Thanks!