Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORDEX-CMIP6 cmor tables #677

Closed
larsbuntemeyer opened this issue Oct 10, 2022 · 7 comments
Closed

CORDEX-CMIP6 cmor tables #677

larsbuntemeyer opened this issue Oct 10, 2022 · 7 comments

Comments

@larsbuntemeyer
Copy link

Hey everybody,
i have some issues since i am working on CMOR tables for downscaling of CMIP6 datasets. I try to understand some of the attribute dependencies and i have some preliminary tables here and a rendered example. For theses tests i have basically adapted the CMIP6_CV table and modified them. This all works fine, however, in CORDEX we don't require any parent_* or sub_* attributes and i tried to remove them completely from the CV and the dataset table. But somehow i can't get it to work, since i always get something like:

!!!!!!!!!!!!!!!!!!!!!!!!!
!
! Error: Your "sub_experiment_id" key could not be found in
! your Control Vocabulary file.
! 
!
!!!!!!!!!!!!!!!!!!!!!!!!!

So the cmorizer looks for that attribute although it is not defined or required either in the dataset table nor in the CV table. Is there some special attributes for CMOR3 that are required? I suspect so when i have a look at the source code, e.g., here

int cmor_CV_checkSubExpID(cmor_CV_def_t * CV)
it seems like this is somehow hardcoded and required?

At the same time, i wonder how this works, e.g., with the input4MIps or obs4MIPs tables since they don't define, e.g., the sub_experiment attributes...

Maybe i get something totally wrong, i am not sure...

@larsbuntemeyer
Copy link
Author

larsbuntemeyer commented Oct 10, 2022

Ok, i now see that this behaviour is activated by the presence of the _cmip6_option keyword in the dataset table... So i guess this should be absent if one wants to define an arbitrary CV?

@larsbuntemeyer
Copy link
Author

larsbuntemeyer commented Oct 10, 2022

Just one hint for myself here:

If i have derived attributes in the CV, e.g., source depends on source_id, i have to specify both in the input datasets table (because i want both required), however, conflicting values of derived attributes are overwritten silently now. Could there be a warning if derived attributes are overwritten?

Is it correct that i have to specifiy derived required attributes in the dataset table (although theoretically they could be added automatically since they are overwritten anyway...)?

@durack1
Copy link
Contributor

durack1 commented Oct 10, 2022

@larsbuntemeyer you're almost there, if you wanted to see some of the CMOR_input_example.json inputs for the input4MIPs project, take a peek at PCMDI/amipbcs/CMOR/drive_input4MIPs_obs.json.

As you noted this does NOT include the _cmip6_option and thanks to the recent CMOR 3.7.0 release, depends on most of the inputs from the registered content (in the input4MIPs case information found in the https://github.com/PCMDI/input4MIPs-cmor-tables (and specifically the info found in the PCMDI/input4MIPs-cmor-tables/Tables/input4MIPs_CV.json) file

@larsbuntemeyer
Copy link
Author

larsbuntemeyer commented Oct 10, 2022

Thanks @durack1 for that swift reply! I appreciate it! I guess, there is no way to configure PrePARE to run with arbitrary CV, is there? For example, could you run PrePARE on input4MIPs datasets?

@larsbuntemeyer
Copy link
Author

@larsbuntemeyer you're almost there, if you wanted to see some of the CMOR_input_example.json inputs for the input4MIPs project, take a peek at PCMDI/amipbcs/CMOR/drive_input4MIPs_obs.json.

As you noted this does NOT include the _cmip6_option and thanks to the recent CMOR 3.7.0 release, depends on most of the inputs from the registered content (in the input4MIPs case information found in the https://github.com/PCMDI/input4MIPs-cmor-tables (and specifically the info found in the PCMDI/input4MIPs-cmor-tables/Tables/input4MIPs_CV.json) file

Yes, i updated to the latest version, now this makes the input file really slim and convenient, very nice!!

@durack1
Copy link
Contributor

durack1 commented Oct 10, 2022

@larsbuntemeyer it makes sense to me that we migrate this "issue" into a "discussion" as there is no obvious issue or bug that this thread identifies, rather it's about CMOR usage (and potential expansion/features)

@larsbuntemeyer
Copy link
Author

I agree!

@PCMDI PCMDI locked and limited conversation to collaborators Oct 10, 2022
@durack1 durack1 converted this issue into discussion #679 Oct 10, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@durack1 @larsbuntemeyer and others