Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please merge integration test #15

Closed
wants to merge 4 commits into from
Closed

Conversation

apeckham
Copy link

Philip,

Thank you for ruby_route_53!

These changes add an integration test that creates and deletes actual zones and records with AWS. It uses VCR to record AWS's responses, and uses the recorded responses on future runs. 68% of the lines are executed by the test.

I'd like to do more -- refactoring, unit testing and adding features -- but I'd first like to have this integration test in place to prevent regressions.

Thanks,

Aaron

@pcorliss
Copy link
Owner

This reply is long-long overdue, but I've integrated some specs but went another direction. Thanks for the pull request but closing for now.

@pcorliss pcorliss closed this Jan 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants