Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App’s stuck and dragging Electron app over causes JS error #3

Closed
gryzzly opened this issue Nov 20, 2019 · 10 comments
Closed

App’s stuck and dragging Electron app over causes JS error #3

gryzzly opened this issue Nov 20, 2019 · 10 comments

Comments

@gryzzly
Copy link

gryzzly commented Nov 20, 2019

The app is stuck with the spinner.

Dragging the installed app over causes JS error:

Screenshot 2019-11-20 at 19 35 14

Using Macbook Pro with macOS 10.14.6 (18G103).

Debugtron version 0.4.0.

Let me know if I can help debugging this or I am doing something wrong.

@pd4d10
Copy link
Owner

pd4d10 commented Nov 23, 2019

Hi @gryzzly, thanks for your report!

Probably there are two issues:

  1. The stuck is caused by the Electron apps detection step. It looks like some errors are not handled correctly in the detection step. Could you please provide a screenshot of your apps' list?
  2. DnD errors also not be handled correctly. Could you please provide the app you are trying to drop? The name of it would be enough if it can be publicly downloaded.

If the above information relates to your privacy, it doesn't matter if you don't post it here :)

@pd4d10
Copy link
Owner

pd4d10 commented Nov 23, 2019

For macOS, the Electron app detection implementation is in this file:

https://github.com/bytedance/debugtron/blob/998a9ced2ee86e18a57a5bdf8b43aa5ece8fc77d/src/main/macos.ts#L14

Discussions and PRs are very welcome if you want to debug it yourself.

@imyzf
Copy link

imyzf commented Nov 27, 2019

image

+1,only available when I opened at first time. When I open it again, it is stuck with the spinner.

Using mac mini with macOS 10.14.6 (18G1012).
Debugtron version 0.4.0.

@pd4d10
Copy link
Owner

pd4d10 commented Dec 2, 2019

Hi, @gryzzly @imyzf , we have likely found the reason causing this issue, which probably has been fixed in the latest v0.4.1. Please give it a try.

@imyzf
Copy link

imyzf commented Dec 2, 2019

The error is disappeared, but the spinner exists. Need I clean any storage file before update?

@pd4d10
Copy link
Owner

pd4d10 commented Dec 3, 2019

@imyzf OK, thanks for the feedback. Seems it has a problem with the Electron apps detection step.

Since the error is disappeared, is the drag feature working as expected?

@imyzf
Copy link

imyzf commented Dec 4, 2019

is the drag feature working as expected?

No, it does nothing.

@pd4d10
Copy link
Owner

pd4d10 commented Dec 24, 2019

Hi, @imyzf @gryzzly , this issue is probably related to #4.

v0.4.2 has been released to fix this.

@imyzf
Copy link

imyzf commented Dec 24, 2019

Great! It works!

@pd4d10
Copy link
Owner

pd4d10 commented Jan 15, 2020

Hi, I'm going to close this. Feel free to reopen it

@pd4d10 pd4d10 closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants