Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid packaging #153

Closed
benmccann opened this issue Feb 27, 2022 · 2 comments
Closed

Invalid packaging #153

benmccann opened this issue Feb 27, 2022 · 2 comments

Comments

@benmccann
Copy link

Hi, I'm a maintainer on Svelte and saw some bug reports that bytemd doesn't work with SvelteKit, so I wanted to offer some advice

In master, these two lines point to a .ts file for the entry point. It is recommended to preprocess your library and distribute .js files instead.
https://github.com/bytedance/bytemd/blob/e2fbd0689303b2baa5917a4b1c3bd87ae1108168/packages/bytemd/package.json#L18
https://github.com/bytedance/bytemd/blob/e2fbd0689303b2baa5917a4b1c3bd87ae1108168/packages/bytemd/package.json#L27

I also noticed some packaging issues with latest released version 1.11.0. In that version you have a CJS main entry point importing a Svelte component. It is recommended to only distribute Svelte packages as ESM

You can use the svelte-kit package command to generate packages in the recommended format: https://kit.svelte.dev/docs/packaging

@pd4d10
Copy link
Owner

pd4d10 commented Mar 1, 2022

Thanks for the information!

Already replied at https://github.com/bytedance/bytemd/issues/96

@pd4d10
Copy link
Owner

pd4d10 commented Mar 26, 2022

It should have been fixed in the latest version.

Since #96 has the most context, Let's track this issue there.

@pd4d10 pd4d10 closed this as completed Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants