Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/svelte-rollup/package.json does not depend on bytemd? #19

Closed
koo5 opened this issue Dec 17, 2020 · 3 comments
Closed

examples/svelte-rollup/package.json does not depend on bytemd? #19

koo5 opened this issue Dec 17, 2020 · 3 comments

Comments

@koo5
Copy link

koo5 commented Dec 17, 2020

and even if i npm i bytemd in the directory, i still get Uncaught ReferenceError: bytemd is not defined in browser console.
@pd4d10
Copy link
Owner

pd4d10 commented Dec 18, 2020

Oh, these packages are actually missing. Because in the development case these packages are resolved in the root node_modules.

Run yarn && yarn dev at the root directory should solve this issue.

@pd4d10
Copy link
Owner

pd4d10 commented Dec 18, 2020

In your own project, these packages should be installed manually if used.

@pd4d10
Copy link
Owner

pd4d10 commented Feb 28, 2021

We use pnpm in the latest main branch and include examples in the monorepo workspace.

So this should have been fixed.

@pd4d10 pd4d10 closed this as completed Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koo5 @pd4d10