GHA: Compute coverage in only one job #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
+ Coverage 79.28% 79.37% +0.08%
==========================================
Files 12 13 +1
Lines 4837 4858 +21
==========================================
+ Hits 3835 3856 +21
Misses 1002 1002 ☔ View full report in Codecov by Sentry. |
|
Wrong way. I'll switch to https://about.codecov.io/blog/uploading-code-coverage-in-a-separate-job-on-github-actions/ |
jeromerobert
force-pushed
the
fixcodecovrace
branch
4 times, most recently
from
3c50e9b
to
be06786
Compare
jeromerobert
force-pushed
the
fixcodecovrace
branch
3 times, most recently
from
4c92653
to
9525785
Compare
Uploading from multiple jobs cause races
jeromerobert
force-pushed
the
fixcodecovrace
branch
from
d5bbca7
to
1d0d5c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might create race as we don't know how codecov is interpreting this