export type annotations in package #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about this. Only after I tried to use the new release in my own tool did I discover this was necessary :( |
0xabu
added a commit
to 0xabu/pdfannots
that referenced
this pull request
Oct 12, 2021
Unfortunately broken, due to the absence of pdfminer/pdfminer.six#679
No worries! Thanks for adding these great features to pdfminer.six! |
Beants
added a commit
to HiTalentAlgorithms/pdfminer.six
that referenced
this pull request
Feb 14, 2022
* develop: Check blackness in github actions (pdfminer#711) Changed `log.info` to `log.debug` in six files (pdfminer#690) Update README.md batch for Continuous integration Update actions.yml so that it will run for all PR's Update development tools: travis ci to github actions, tox to nox, nose to pytest (pdfminer#704) Added feature: page labels (pdfminer#680) Remove obsolete returns (pdfminer#707) Revert "Remove obsolete returns" Remove obsolete returns Only use xref fallback if `PDFNoValidXRef` is raised and `fallback` is True (pdfminer#684) Use logger.warn instead of warnings.warn if warning cannot be prevented by user (pdfminer#673) Change log.info into log.debug to make pdfinterp.py less verbose Fix regression in page layout that sometimes returned text lines out of order (pdfminer#659) export type annotations in package (pdfminer#679) fix typos in PR template (pdfminer#681) pdf2txt: clean up construction of LAParams from arguments (pdfminer#682) Fixes jbig2 writer to write valid jb2 files Add support for JPEG2000 image encoding Added test case for CCITTFaxDecoder (pdfminer#700) Attempt to handle decompression error on some broken PDF files (pdfminer#637)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
py.typedmarker file to our package, which is necessary for tools such as mypy to discover pdfminer's new type annotations when it is installed via pypi.This fixes mypy errors such as the following in downstream tools:
References:
https://www.python.org/dev/peps/pep-0561/#packaging-type-information
https://mypy.readthedocs.io/en/stable/installed_packages.html#creating-pep-561-compatible-packages
How Has This Been Tested?
I built a wheel, installed it locally, and verified that mypy no longer issues the errors that it does with the 20211012 release.