Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test case for CCITTFaxDecoder #700

Merged
merged 8 commits into from
Jan 23, 2022
Merged

Added test case for CCITTFaxDecoder #700

merged 8 commits into from
Jan 23, 2022

Conversation

pietermarsman
Copy link
Member

Copy of #642


Thanks for this great project!

The tostring method has been deprecated since Python 3.2 and was
removed altogether in 3.9. In Python 3.2 the method was renamed
to "tobytes"

Without this fix, using the ccit module will lead to an AttributeError and a crash on Python 3.9+.

Will close #641

How Has This Been Tested?

Ran locally with python 3.9

Checklist

I have added tests that prove my fix is effective or that my feature
works.
I have added docstrings to newly created methods and classes not relevant
I have optimized the code at least one time after creating the initial
version
I have updated the README.md or I am verified that this
is not necessary
I have updated the readthedocs documentation or I
verified that this is not necessary
I have added a consice human-readable description of the change to
CHANGELOG.md

fgregg and others added 7 commits July 14, 2021 08:55
The tostring method has been deprecated since Python 3.2 and was
removed altogether in 3.9. In Python 3.2 the method was renamed
to "tobytes"

Will close #641
@pietermarsman pietermarsman changed the title Tobytes array.array.tostring -> array.array.tobytes Jan 23, 2022
@pietermarsman pietermarsman changed the title array.array.tostring -> array.array.tobytes Added test case for CCITTFaxDecoder Jan 23, 2022
@pietermarsman
Copy link
Member Author

Actual error was already fixed by #661. So only adding test case.

@pietermarsman pietermarsman merged commit b822292 into develop Jan 23, 2022
Beants added a commit to HiTalentAlgorithms/pdfminer.six that referenced this pull request Feb 14, 2022
* develop:
  Check blackness in github actions (pdfminer#711)
  Changed `log.info` to  `log.debug` in six files (pdfminer#690)
  Update README.md batch for Continuous integration
  Update actions.yml so that it will run for all PR's
  Update development tools: travis ci to github actions, tox to nox, nose to pytest (pdfminer#704)
  Added feature: page labels (pdfminer#680)
  Remove obsolete returns (pdfminer#707)
  Revert "Remove obsolete returns"
  Remove obsolete returns
  Only use xref fallback if `PDFNoValidXRef` is raised and `fallback` is True (pdfminer#684)
  Use logger.warn instead of warnings.warn if warning cannot be prevented by user (pdfminer#673)
  Change log.info into log.debug to make pdfinterp.py less verbose
  Fix regression in page layout that sometimes returned text lines out of order (pdfminer#659)
  export type annotations in package (pdfminer#679)
  fix typos in PR template (pdfminer#681)
  pdf2txt: clean up construction of LAParams from arguments (pdfminer#682)
  Fixes jbig2 writer to write valid jb2 files
  Add support for JPEG2000 image encoding
  Added test case for CCITTFaxDecoder (pdfminer#700)
  Attempt to handle decompression error on some broken PDF files (pdfminer#637)
@pietermarsman pietermarsman deleted the tobytes branch March 19, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tostring method of array has been deprecated since python 3.2 and removed in python 3.9
2 participants