Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed log.info to log.debug in six files #690

Merged
merged 4 commits into from
Feb 8, 2022

Conversation

pedrounes1
Copy link

@pedrounes1 pedrounes1 commented Nov 18, 2021

Fix #608

As said in issue #608, high_level.extract_text was logging out when root logger level is info. I think that, ideally, it only should log when logger level == debug. To do that, I changed log.info to log.debug on the following files:

  • pdfminer/cmapdb.py
  • pdfminer/converter.py
  • pdfminer/pdfdocument.py
  • pdfminer/pdfinterp.py
  • pdfminer/pdfpage.py
  • pdfminer/psparser.py

All the tox/Travis CI tests had passed. As is this just a small/cosmetic fix, I think that does not require additional tests.

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial version
  • I have updated the README.md or I am verified that this is not necessary
  • I have updated the readthedocs documentation or I verified that this is not necessary
  • I have added a consice human-readable description of the change to CHANGELOG.md

@pietermarsman pietermarsman merged commit 830acff into pdfminer:develop Feb 8, 2022
Beants added a commit to HiTalentAlgorithms/pdfminer.six that referenced this pull request Feb 14, 2022
* develop:
  Check blackness in github actions (pdfminer#711)
  Changed `log.info` to  `log.debug` in six files (pdfminer#690)
  Update README.md batch for Continuous integration
  Update actions.yml so that it will run for all PR's
  Update development tools: travis ci to github actions, tox to nox, nose to pytest (pdfminer#704)
  Added feature: page labels (pdfminer#680)
  Remove obsolete returns (pdfminer#707)
  Revert "Remove obsolete returns"
  Remove obsolete returns
  Only use xref fallback if `PDFNoValidXRef` is raised and `fallback` is True (pdfminer#684)
  Use logger.warn instead of warnings.warn if warning cannot be prevented by user (pdfminer#673)
  Change log.info into log.debug to make pdfinterp.py less verbose
  Fix regression in page layout that sometimes returned text lines out of order (pdfminer#659)
  export type annotations in package (pdfminer#679)
  fix typos in PR template (pdfminer#681)
  pdf2txt: clean up construction of LAParams from arguments (pdfminer#682)
  Fixes jbig2 writer to write valid jb2 files
  Add support for JPEG2000 image encoding
  Added test case for CCITTFaxDecoder (pdfminer#700)
  Attempt to handle decompression error on some broken PDF files (pdfminer#637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why extract_text function log automatically?
2 participants