Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't touch caches if no-cache is given #2913

Merged
merged 2 commits into from
May 29, 2024

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Signed-off-by: Frost Ming <me@frostming.com>
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.34%. Comparing base (28fd928) to head (5e4896f).
Report is 100 commits behind head on main.

Files Patch % Lines
src/pdm/models/caches.py 60.00% 4 Missing ⚠️
src/pdm/models/candidates.py 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2913      +/-   ##
==========================================
- Coverage   85.36%   85.34%   -0.02%     
==========================================
  Files         106      106              
  Lines       10623    10629       +6     
  Branches     2313     2314       +1     
==========================================
+ Hits         9068     9071       +3     
- Misses       1089     1090       +1     
- Partials      466      468       +2     
Flag Coverage Δ
unittests 85.12% <75.75%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming merged commit d925136 into main May 29, 2024
20 of 24 checks passed
@frostming frostming deleted the fix--don't-touch-caches-if-no-cache-is-given branch May 29, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant