Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a resize command #40

Merged
merged 1 commit into from
Jun 21, 2013
Merged

Add a resize command #40

merged 1 commit into from
Jun 21, 2013

Conversation

blom
Copy link
Collaborator

@blom blom commented Jun 19, 2013

Since there is only one API option (size_id) and it is required, perhaps the syntax should be like it is for snapshot. Although it would feel more natural to say resize fuzzy_name new_name instead. In any case, I used create's syntax here as a start.

@pearkes
Copy link
Collaborator

pearkes commented Jun 20, 2013

Hm, I tend to agree with you. It's kind of nice to be able to do it like snapshot.

Maybe something like this? Make -s required in this case?

tugboat resize web-001 -s 414

Or were you thinking

tugboat resize web-001 414

@blom
Copy link
Collaborator Author

blom commented Jun 20, 2013

I have implemented it like you outline in the first example: tugboat resize web-001 -s 414. I can instead model it after snapshot if you want? The only thing about the snapshot way that feels unnatural to me is that the size has to come before the fuzzy name, since the fuzzy name is an optional argument.

@pearkes
Copy link
Collaborator

pearkes commented Jun 21, 2013

I think how you did it was the right way, personally. I'm going to add to the README on this branch too.

@pearkes
Copy link
Collaborator

pearkes commented Jun 21, 2013

Oh, you're on your fork! I'll make the README changes post merge. I think there are some other commands I have to add as well.

Feel free to branch off of this repo in the future, if you want.

pearkes added a commit that referenced this pull request Jun 21, 2013
@pearkes pearkes merged commit 44607ac into petems:master Jun 21, 2013
@blom
Copy link
Collaborator Author

blom commented Jun 22, 2013

Yeah, I have continued pushing to my own fork mainly out of old habit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants