Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default source with ADC support #94

Closed
bbhoss opened this issue Mar 17, 2021 · 1 comment
Closed

Add default source with ADC support #94

bbhoss opened this issue Mar 17, 2021 · 1 comment

Comments

@bbhoss
Copy link

bbhoss commented Mar 17, 2021 •
edited
Loading

As mentioned in #77, Goth should support ADC. Additionally Goth should Just Work™️ out of the box without needing to provide an explicit source in the case that default credentials exist. I propose we mirror the google-auth Python library that I suspect most GCP users have experience with. They have the order of defaults to use documented here. I propose we mirror this order where Goth supports the auth methods (it's unclear the GAE method is supported).
@wojtekmach
Copy link
Collaborator

wojtekmach commented Apr 26, 2021 •
edited
Loading

We don't plan to tackle this so I'm going to close this for now but a PR will be very welcome, thanks!

@wojtekmach wojtekmach mentioned this issue May 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbhoss @wojtekmach