Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect example in README #23

Closed
rubikskub opened this issue Mar 18, 2019 · 2 comments
Closed

Incorrect example in README #23

rubikskub opened this issue Mar 18, 2019 · 2 comments

Comments

@rubikskub
Copy link

Using this example code in the README for subscribing we received a 404 response from GCP:

subscription = %Kane.Subscription{topic: %Kane.Topic{name: "my-topic"}

Changing it to:

subscription = %Kane.Subscription{name: "my-topic"}

seems to work better.

@peburrows
Copy link
Owner

I think the most correct syntax is actually somewhere between those two:

%Kane.Subscription{
  name: "my-sub",
  topic: %Kane.Topic{
    name: "my-topic"
  }
}

I'll update the README to fix things.

@peburrows
Copy link
Owner

b88f364 should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants