Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish the new testing method #23

Closed
1 task done
pedrobcst opened this issue Apr 6, 2022 · 0 comments · Fixed by #24
Closed
1 task done

Finish the new testing method #23

pedrobcst opened this issue Apr 6, 2022 · 0 comments · Fixed by #24
Assignees

Comments

@pedrobcst
Copy link
Owner

pedrobcst commented Apr 6, 2022

As of currently, we have a possible new 'cif' testing method which is much faster and does not do any refinement. After the changes on how the default 'refinement' is done and modifying the simulations tests to be handled in place (when the data is being simulated), Xerus became much more stabler. The only 'test' now required is if GSASII engine can actually parse a CIF coming from a provider. The new tests justs then tries to open a CIF file using GSASII using a dummy project. This leads to a large increase of possible structures available that before were considered "system breaking".

This has to be implemented before #22.
TODO:

  • Re run benchmarks using new testing method on a clean mock database.
@pedrobcst pedrobcst self-assigned this Apr 6, 2022
@pedrobcst pedrobcst mentioned this issue Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant