You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My view is that we should start explicitly treating them as strings, as they are identifiers and they will never need to be treated as numbers. This would be a simple enough change, would only require JSON_BIGINT_AS_STRING and (string) casts.
There would be no need to add any additional validation that the string is numeric, since we can assume that anything returned by the API is valid, and in any operations where we send an ID to the API we already need to be prepared for errors that result from passing an identifier that doesn't exist.
This solves the 32-bit issue, and skirts any future issues we might hit because of numeric casting weirdness.
Considering this is a breaking change I will fix this in some future release. Probably https://github.com/aenglander/amp-twitter-bot also need updating so once I made the change we need to PR downstream.
Twitter id's don't fit in 32b integers. Should we loosen the type declaration from
int
tostring
to support 32b systems?Related to #12
The text was updated successfully, but these errors were encountered: