Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support stream through IPFS daemon #285

Open
pgte opened this issue Jan 17, 2019 · 6 comments
Open

support stream through IPFS daemon #285

pgte opened this issue Jan 17, 2019 · 6 comments

Comments

@pgte
Copy link
Collaborator

pgte commented Jan 17, 2019

One of the reasons why we were not able to use an IPFS daemon instead of an embedded js-ipfs node was because go-ipfs didn't allow for p2p streams. But go-ipfs now it does have the p2p command which opens a duplex stream.

(/cc @whyrusleeping)

@parkan
Copy link
Collaborator

parkan commented Jan 17, 2019

for clarity, this would work through companion, correct?

@pgte
Copy link
Collaborator Author

pgte commented Jan 17, 2019

Apparently js-ipfs does not support this, so I think companion doesn't either.
Opened respective issue on js-ipfs for clarification.

@whyrusleeping
Copy link

Cc @magik6k (the author of these features on the go side)

@magik6k
Copy link

magik6k commented Jan 21, 2019

So go-ipfs exposes libp2p streams via ipfs p2p for quite a while already, but it's not really useful for browsers since it requires use of native sockets.

There was some discussion on creating a websocket interface to these commands to enable browsers to open/listen for p2p streams, but iirc the conclusion was to focus on https://github.com/libp2p/go-libp2p-daemon, and just support websockets there

@magik6k
Copy link

magik6k commented Jan 21, 2019

(AFAIK it should be possible to implement on the extension level, cc @lidel)

@pgte
Copy link
Collaborator Author

pgte commented Jan 22, 2019

@magik6k ha, thanks for the feedback! If it's not websockets we can't use it directly in the browser context, and we would need this to be in the IPFS daemon..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants