Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R6 Eddington class cannot be saved without data loss. #3

Open
pegeler opened this issue Mar 28, 2020 · 0 comments
Open

R6 Eddington class cannot be saved without data loss. #3

pegeler opened this issue Mar 28, 2020 · 0 comments
Assignees

Comments

@pegeler
Copy link
Owner

pegeler commented Mar 28, 2020

The hash map of ride history is just a pointer (Rcpp::XPtr) to a std::unordered_map. So if a user attempts to save the Eddington class using save() or saveRDS(), they will be disappointed when reloading data since the pointer will be nil and the data will be lost.

This means that in current-state, several functions will not work as intended when attempting to manipulate the same object between sessions. Some will error silently (like the update() method) and others will raise an error (like attempting to access the H active field).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant