Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace download link with new one in doc #61

Open
crapthings opened this issue Apr 17, 2021 · 3 comments · Fixed by #62
Open

Replace download link with new one in doc #61

crapthings opened this issue Apr 17, 2021 · 3 comments · Fixed by #62
Assignees

Comments

@crapthings
Copy link

https://github.com/peggyjs/peggy/blob/main/docs/index.html#L53

            <span id="download">
                <a
                    title="Download a minified version of Peggy for the browser"
                    href="https://github.com/pegjs/pegjs/releases/download/v0.10.0/peg-0.10.0.min.js"
                >minified</a>
                |
                <a
                    title="Download Peggy for the browser"
                    href="https://github.com/pegjs/pegjs/releases/download/v0.10.0/peg-0.10.0.js"
                >development</a>
            </span>

the old release has js file with release

image

so where we link new peggy?

@hildjj hildjj self-assigned this Apr 17, 2021
hildjj added a commit to hildjj/peggy that referenced this issue Apr 17, 2021
@hildjj
Copy link
Contributor

hildjj commented Apr 17, 2021

I've only got a minified build handy with the current build process. Once we're done with #60, hopefully there will be a sourcemap'd version in github, which will be appropriate for development use.

@hildjj
Copy link
Contributor

hildjj commented Apr 17, 2021

Adding a download attribute wouldn't cause a download because this is being served cross-site. Re-opening so this can be re-fixed after #60.

@hildjj hildjj reopened this Apr 17, 2021
@hildjj
Copy link
Contributor

hildjj commented Mar 1, 2023

This no longer depends on #60. This could just be a download link to https://peggyjs.org/vendor/peggy/peggy.min.js, but I want to make it clear that people should be caching it from unpkg rather than github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants