update SQLite schema and add filter to remove alt-geometries #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small PR into #487 that allows country codes to be specified in upper case or lower case. Before this, specifying country codes in anything but lowercase would cause the downloader to skip all files.
This helps ensure that in the future we don't break anything that depends on this module by exporting something that doesn't exist.
Add tests for module exports
orangejulius
force-pushed
the
ignore-alt-geoms
branch
from
31b0197
to
2b29a7b
Compare
orangejulius
force-pushed
the
joxit/data-geocode-earth
branch
from
a18f477
to
6ba6c1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR into joxit/data-geocode.earth.
The
pelias/wof-admin-lookupmodule requires this module and uses it to load geometries from SQLite databases.I noticed a bunch of warnings when loading the PIP service using the local resolver as such:
It seems that although the WOF SQLite schema supports alt geometries, they never published data including them, whereas GeocodeEarth does, so we're adhering to the spec ahead of the canonical releases.
So this PR ensures that, by default, alt geometries are not loaded when using the
SQLiteStreamclass.We may wish to support them later but this at least gets any dependant codebases back to where they were.