Always use sqlite as data source #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
force-pushed
the
drop-bundle-support
branch
from
fa095c7
to
1b144ca
Compare
BREAKING CHANGE: This implements a hard switchover to using SQLite files for admin lookup. Using bundle files is no longer supported, and as a result the `imports.whosonfirst.sqlite` setting is now ignored. `wof-admin-lookup` will now behave as if that flag was always set to true. Closes #293
orangejulius
force-pushed
the
drop-bundle-support
branch
from
1b144ca
to
adedf14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This implements a hard switchover to using SQLite files
for admin lookup. Using bundle files is no longer supported, and as a
result the
imports.whosonfirst.sqlitesetting is now ignored.wof-admin-lookupwill now behave as if that flag was always set totrue.
This PR requires pelias/whosonfirst#498 to be merged first