Skip to content
This repository has been archived by the owner on Aug 17, 2024. It is now read-only.

Consider adding serde support ? #43

Closed
daladim opened this issue Nov 5, 2021 · 3 comments
Closed

Consider adding serde support ? #43

daladim opened this issue Nov 5, 2021 · 3 comments

Comments

@daladim
Copy link
Contributor

daladim commented Nov 5, 2021

Thanks for this crate.

I wished it had a serde cargo feature, so that I could include e.g. parsed Propertys into my own structs that #[derive(Serialize)].

I can work around this by writing my own serializer (which is not terribly difficult), but it would be better if it was already included in your crate (I haven't really tried yet, but reading quickly into the serde documentation, it looks like the latter is more difficult than the former, so I'm not even sure I'll be able to do this myself and make a MR for this :-/ )

@daladim
Copy link
Contributor Author

daladim commented Nov 10, 2021

I've done this in #44 , that was actually very simple

@Peltoche
Copy link
Owner

Hello @daladim,

You review have been merged so I close this issue.

Thanks again for the contribution.

@daladim
Copy link
Contributor Author

daladim commented Nov 23, 2021

Thanks @Peltoche. When are you considering releasing a new version of ical?

I'd like to publish a crate that depends on yours (including my commit), but I cannot do so in case a dependency of mine is not published either :-(

@daladim daladim mentioned this issue Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants