-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client for observing state and dynamically changing configuration #119
Comments
I would suggest moving the changing of log-level into config as well, as it can have availability impact depending on what is done with the log output (trace may overwhelm log storage). Furthermore, I'm missing socket for observing in the list of sockets. |
well we discussed that the configuration that actually changes how the clock behaves (e.g. when to step) should be separate from the logging configuration. These two can then get different permissions (e.g. with user groups). My impression was that you can control the permissions on the socket (it's just a file, after all) and hence there are two sockets: one with minimal permissions that adjusts logs (and perhaps other behavior that does not impact the clock steering), and one with more restrictive permissions that can actually change how clock steering operates (changing peers, when to jump, ect). |
I'd probably try to find a more generic name for |
According to my notes and what i remember the discussion was more on splitting the interactive (configuration-changing) part from the non-interactive readout part (e.g. the measurements) so that things like node-exporter don't need excessive permissions to get statistics. |
I also don't really see the value in splitting of one part of the interactive socket from another to be honest |
we have two unix sockets, by default
the log level is unprotected, the config needs additional permissions.
we can use https://docs.rs/tokio/latest/tokio/net/struct.UnixStream.html
for sending data over the socket, use https://docs.rs/postcard/latest/postcard/ ? (or send json as bytes?)
then we also need some observability features, some ideas
The text was updated successfully, but these errors were encountered: