Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - block subdirectories only #9

Closed
phaseism opened this issue Jan 4, 2022 · 6 comments · Fixed by #13
Closed

Feature request - block subdirectories only #9

phaseism opened this issue Jan 4, 2022 · 6 comments · Fixed by #13

Comments

@phaseism
Copy link

phaseism commented Jan 4, 2022

Appreciate the work you've done. Really like how simple and easy it is.
Any way to block specific subdomains but still allow top domain? i.e. block youtube.com/user/BBC but still allow youtube.com

@penge
Copy link
Owner

penge commented Jan 5, 2022

Thank you! Only domains are blocked at the moment, but this could be extended to block paths like in the example. Let me have a look at it.

@lumoe
Copy link

lumoe commented Jan 12, 2022

That would be indeed a great feature!
In my case I want to block youtube.com but allow music.youtube.com.

@lumoe
Copy link

lumoe commented Jan 13, 2022

I started to experiment with the following:

  1. Have a second textarea that works as an Allowlist
  2. Allow the user to input RegEx to match against the pathname and hostname

I think a combination of both is required to cover all needs and not break users current blocklist.

What do you think is the best approach for this?

@penge
Copy link
Owner

penge commented Jan 13, 2022

I would try to keep in inside a single textarea, where whitelisted (exceptions to the rule) would start with !.
Example:

youtube.com
!music.youtube.com

Meaning, block youtube.com, but allow music.youtube.com.
What do you think?

@lumoe
Copy link

lumoe commented Jan 13, 2022

The reason behind introducing a second textarea was that it might be more intuitive for non-tech-savvy users.

But agreed, this is the simplest solution for this problem that can be implemented rather quick. I will implement a solution for this and create a pull request.

@penge
Copy link
Owner

penge commented Jan 13, 2022

Souds great @lumoe, thank you.

@penge penge changed the title Feature request - block subdomain Feature request - block paths only Jan 13, 2022
@penge penge changed the title Feature request - block paths only Feature request - block subdirectories only Jan 13, 2022
@penge penge closed this as completed in #13 Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants