errant "text" label on K in DomainInterop diagram #460
Assignees
Labels
Comments
kai-qu
pushed a commit
that referenced
this issue
Feb 3, 2021
* [scp] add style program JSON conversion in backend, and add example JSON file (for orthogonal vectors) in frontend tests. also add orthogonal vectors to registry * [scp] add input types + implementation stub for style compiler * [scp] fix indentation * [scp] fix indentation, add some work on selector checking * [scp] finish selector environment-building code (with selector in env for debugging); all error-checking omitted * [scp] implement some of the substitution finding code * [parser] fix off-by-one-error in selector parsing * [scp] get (ported part of) style compiler compatible with ASTs, no crash but haven't checked correctness of SelEnvs yet * [scm] confirm + improve SelEnv schema * [scm] add some misc sel checking functions * [scp] add test compiler data for linear-algebra-simple.sty, as well as tests for substitution-finding helper functions * [scp] add some function stubs for style matching * [scp] add rel-substitution code (unrun/untested) and documentation of compiler so far * [scp] add rel pretty-printing code and informally verify that all substitution code works (with a minor parser/AST incompatibility in RelPred name). TODO write tests for substitution code * [scp] update compiler and parsed ASTs to deal with minor changes in parser/grammar fixing #436 #437 * [scp] test substitutions (and regenerate style test data WRT parser change) * [scp] add code for testing that a substituted relational line matches a substance program line + code for converting style exprs/predicates to substance ones. add (passing) test that the compiler finds right substitutions on the LA style program * [scp] add code for replacing anon statements with local vars, as well as (passing) test * [scp] add some boilerplate for writing style program translation code * [scp] add some boilerplate for style translation and substitution-applying code * [scp] finish substitution-applying code (not fully tested, but runs); add hacks for issues #443 #444 * [scp] add some translation code (currently not working on GPIs and w/ a hack for local vars); update for #443 #444 * [scp] integrate LocalVar with Path grammar (since parser parses into that form, not IInternalLocalVar) and remove hacks related to it * [scp] add GPI insertion; compiler generates first translation before genOptProblem (untested) * [scp] add boilerplate genOptProblem + initial state * [scp] add some genOptProblem code for finding various kinds of paths in the translation * [scp] add most of the rest of genOptProblem code for generating translation (except initShape and initProperty) * [scp] fix circular import of canvasSize * [scp] fix bug in finding varying val in vector * [scp] add shape initialization code (untested) * [scp] fix varying property finding bug; add `insertNames` * [scp] fix `findExpr` bug on vectors; seems like there might be a VarAD (vector) conversion error? runs and generates translation, and crashes on (old) evaluator. [untested] * [scp] convert `penrose-web` to use new AST types throughout; remove `ts-nocheck`; system runs (and crashes at runtime) * [scp] implement `insertLabels` and AccessPath lookup; still crashes on runtime * [scp] get first figure on screen (though with NaNs, number/object errors, etc). fix boolean literal in style program, label Substance objects by default, skip shape layering for now, and add hack for accesspath index parsing (#448) * [scp] fix compiler bug with initializing shape properties; fix Canvas bug with making translation differentiable again (only needed for state w/ old compiler and decodeJSON, now removed); currently crashes on labels * [scp] fix bugs with pending properties and vector sampling; don't use sorted shapes w/ layering; fix bug with updated shape dimensions in translation but not in shapes (not sure why this broke?); initial output looks reasonable, but optimization and resampling are not tested * [scp] render strokeOpacity in Square shape * [scp] comment out old console logs; replace Optimizer logs with console.log for now; fix opt init param + fn name bugs * [scp] first working compiler with optimization and resample (initialize opt weight in compiler; fix shape find bug) * [scp] gather partial layerings in compiler; improve path printing * [scp] load dsl/sub/sty programs using the new toolchain; compiler still needs to be tested * [scp] implement substance equality check and address #448, now LA image appears onscreen (with funky labels) * [scp] implement some selector checking using domain/substance checkers [untested] * [scp] fix bug with Env (`clone` doesn't work; using Map's immutability is better) * [scp] implement more selector checking using Sub/Domain function (for decls) and valcons subtype checking * [scp] implement path aliasing for GPI properties in deleteProperty and insertExpr (for properties only) * [scp] add more test programs for whole thing; works with the set tree example; set circles mostly works except for a selector match bug possibly w/ nested predicates (?) * [scp] hook up new style compiler to CLI and program toolchain, and remove `processData`! working example: `roger watch linear-algebra-domain/twoVectorsPerp_unsugared.sub linear-algebra-domain/linear-algebra-paper-simple.sty linear-algebra-domain/linear-algebra.dsl` * [scp] preprocess Substance program to disambiguate `Func` #453; now the big set circle example works [the functional version of substance preprocessing is just for testing, not final, needs to mutate ast] * [scp] fix Sub prog Func disambiguation to be imperative #453; should now be more general * [scp] get all old examples working (adding unsugared Substance programs, temp string hacks #458, and Style SEFuncOrValCons disambiguation based on the Substance ones). found some label bugs #459 #460 * [scp] revert hacks for #458 * [scp] some cleanup of logs + putting comments back in * [style-compiler-port] hotfix to allow reconnecting to the socket via button * [scp] return errors in `checkSels` and `insertExpr` (if in `compiling` mode) instead of throwing them; clean up some other internal errors * [scp] add some ad-hoc tests for selector errors and translation errors * [scp] fix JS heap issue after 2501f73 #450 * [scp] implement layering sort function * [scp] port old Style compiler tests to work on loaded LA programs Co-authored-by: katherineye <kye@princeton.edu> Co-authored-by: maxkrieger <themaxaxis@gmail.com> Co-authored-by: wodeni <wn2155@columbia.edu>
wodeni
added a commit
that referenced
this issue
Feb 3, 2021
* [scp] add style program JSON conversion in backend, and add example JSON file (for orthogonal vectors) in frontend tests. also add orthogonal vectors to registry * [scp] add input types + implementation stub for style compiler * [scp] fix indentation * [scp] fix indentation, add some work on selector checking * [scp] finish selector environment-building code (with selector in env for debugging); all error-checking omitted * [scp] implement some of the substitution finding code * [parser] fix off-by-one-error in selector parsing * [scp] get (ported part of) style compiler compatible with ASTs, no crash but haven't checked correctness of SelEnvs yet * [scm] confirm + improve SelEnv schema * [scm] add some misc sel checking functions * [scp] add test compiler data for linear-algebra-simple.sty, as well as tests for substitution-finding helper functions * [scp] add some function stubs for style matching * [scp] add rel-substitution code (unrun/untested) and documentation of compiler so far * [scp] add rel pretty-printing code and informally verify that all substitution code works (with a minor parser/AST incompatibility in RelPred name). TODO write tests for substitution code * [scp] update compiler and parsed ASTs to deal with minor changes in parser/grammar fixing #436 #437 * [scp] test substitutions (and regenerate style test data WRT parser change) * [scp] add code for testing that a substituted relational line matches a substance program line + code for converting style exprs/predicates to substance ones. add (passing) test that the compiler finds right substitutions on the LA style program * [scp] add code for replacing anon statements with local vars, as well as (passing) test * [scp] add some boilerplate for writing style program translation code * [scp] add some boilerplate for style translation and substitution-applying code * [scp] finish substitution-applying code (not fully tested, but runs); add hacks for issues #443 #444 * [scp] add some translation code (currently not working on GPIs and w/ a hack for local vars); update for #443 #444 * [scp] integrate LocalVar with Path grammar (since parser parses into that form, not IInternalLocalVar) and remove hacks related to it * [scp] add GPI insertion; compiler generates first translation before genOptProblem (untested) * [scp] add boilerplate genOptProblem + initial state * [scp] add some genOptProblem code for finding various kinds of paths in the translation * [scp] add most of the rest of genOptProblem code for generating translation (except initShape and initProperty) * [scp] fix circular import of canvasSize * [scp] fix bug in finding varying val in vector * [scp] add shape initialization code (untested) * [scp] fix varying property finding bug; add `insertNames` * [scp] fix `findExpr` bug on vectors; seems like there might be a VarAD (vector) conversion error? runs and generates translation, and crashes on (old) evaluator. [untested] * [scp] convert `penrose-web` to use new AST types throughout; remove `ts-nocheck`; system runs (and crashes at runtime) * [scp] implement `insertLabels` and AccessPath lookup; still crashes on runtime * [scp] get first figure on screen (though with NaNs, number/object errors, etc). fix boolean literal in style program, label Substance objects by default, skip shape layering for now, and add hack for accesspath index parsing (#448) * [scp] fix compiler bug with initializing shape properties; fix Canvas bug with making translation differentiable again (only needed for state w/ old compiler and decodeJSON, now removed); currently crashes on labels * [scp] fix bugs with pending properties and vector sampling; don't use sorted shapes w/ layering; fix bug with updated shape dimensions in translation but not in shapes (not sure why this broke?); initial output looks reasonable, but optimization and resampling are not tested * [scp] render strokeOpacity in Square shape * [scp] comment out old console logs; replace Optimizer logs with console.log for now; fix opt init param + fn name bugs * [scp] first working compiler with optimization and resample (initialize opt weight in compiler; fix shape find bug) * [scp] gather partial layerings in compiler; improve path printing * [scp] load dsl/sub/sty programs using the new toolchain; compiler still needs to be tested * [lerna] initialize lerna * [lerna] start deprecating all Haskell related code * [lerna] remove haskell precommmit hook * [lerna] add test script for all packages * [lerna] delete top-level haskell configs * [lerna] install husky in monorepo * [lerna] test husky * [lerna] test husky * fix: install script for roger * v1.0.1 * chore: add changelog * [scp] implement substance equality check and address #448, now LA image appears onscreen (with funky labels) * [scp] implement some selector checking using domain/substance checkers [untested] * [scp] fix bug with Env (`clone` doesn't work; using Map's immutability is better) * [lerna] remove haskell lint config and update ci workflow * [lerna] fix build_other_branches workflow * [lerna] updated CI config * [lerna] install lerna in ci * [lerna] sudo lerna install * [lerna] store test results in CI * [lerna] add junit * Updated config.yml * [lerna] full paths for artifacts * [lerna] collect test report in dedicated directory * [scp] implement more selector checking using Sub/Domain function (for decls) and valcons subtype checking * [scp] implement path aliasing for GPI properties in deleteProperty and insertExpr (for properties only) * [scp] add more test programs for whole thing; works with the set tree example; set circles mostly works except for a selector match bug possibly w/ nested predicates (?) * [lerna] add bootstrap command and test with automator * [lerna] add codecov detector * [scp] hook up new style compiler to CLI and program toolchain, and remove `processData`! working example: `roger watch linear-algebra-domain/twoVectorsPerp_unsugared.sub linear-algebra-domain/linear-algebra-paper-simple.sty linear-algebra-domain/linear-algebra.dsl` * [scp] preprocess Substance program to disambiguate `Func` #453; now the big set circle example works [the functional version of substance preprocessing is just for testing, not final, needs to mutate ast] * [scp] fix Sub prog Func disambiguation to be imperative #453; should now be more general * [scp] get all old examples working (adding unsugared Substance programs, temp string hacks #458, and Style SEFuncOrValCons disambiguation based on the Substance ones). found some label bugs #459 #460 * [scp] revert hacks for #458 * [scp] some cleanup of logs + putting comments back in * [style-compiler-port] hotfix to allow reconnecting to the socket via button * [lerna-merge] fix JS heap issue * [lerna-merge] fix CI JSON issue * [scp] return errors in `checkSels` and `insertExpr` (if in `compiling` mode) instead of throwing them; clean up some other internal errors * [scp] add some ad-hoc tests for selector errors and translation errors * [scp] fix JS heap issue after 2501f73 #450 * [scp] implement layering sort function * [scp] port old Style compiler tests to work on loaded LA programs * [lerna] fix style test case path * [lerna] fix import issue in Style Co-authored-by: katherineye <katherine.ye@gmail.com> Co-authored-by: katherineye <kye@princeton.edu> Co-authored-by: maxkrieger <themaxaxis@gmail.com>
kai-qu
pushed a commit
that referenced
this issue
Feb 10, 2021
|
Fixed in 1a8d41f. |
kai-qu
pushed a commit
that referenced
this issue
Feb 11, 2021
* [sty-errs] move all style selector errors into datatypes with interim error messages * [sty-errs] move style deletion/access errors into datatypes with interim error messages * [sty-errs] combine all existing style errors into error datatypes/string functions and add tests for most of them. not sure why the parsers changed though * [sty-errs] model + print + test the remaining Style errors in `insertExpr`, some of which are runtime ones beyond `compileStyle` * [sty-errs] clean up `venn.sty` * [sty-errs / cleanup] fix override error printing code; fix #460 (remove unneeded escape slash in label) and #459 (handle new LabelMap type correctly; don't put in labels for namespaces) * [sty-errs] add minor comments * [sty-errs] address review comments; return list of errors from `compileStyle` Co-authored-by: katherineye <kye@princeton.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: