-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: don't bundle core #1173
build: don't bundle core #1173
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1173 +/- ##
=======================================
Coverage 63.13% 63.13%
=======================================
Files 59 60 +1
Lines 7060 7061 +1
Branches 1646 1646
=======================================
+ Hits 4457 4458 +1
Misses 2519 2519
Partials 84 84
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
± Registry diff
📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.
Data
|
Currently this gives the following error in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! With this and #1207 merged both core
and components
would be bundleless!
re yarn start
: it's still quite useful to run multiple builds in watch mode. I think we can avoid tsc-alias
by using ttypescript
. I can push a commit for that soon.
Description
We don't need to, as far as I can tell; anything using
@penrose/core
that wants to bundle it should be able to just bundle it directly, so there's no reason to put all our dependencies into the bundle when they're already dependencies of the package itself. This is a followup to #1160, #1165, and #1170. Closes #423.Implementation strategy and design decisions
To increase consistency with our other packages, I changed the
core
build directory frombuild/dist/
to justdist/
. Previouslypackages/synthesizer-ui/README.md
also erroneously said it usedbuild/
instead ofdist/
, so I corrected that here too.Checklist
diagrams/
folder