Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move optimizer into devDependencies #1185

Merged
merged 1 commit into from Jan 3, 2023
Merged

Conversation

samestep
Copy link
Collaborator

@samestep samestep commented Jan 3, 2023

Description

#1092 added a new package, @penrose/optimizer, to the dependencies of @penrose/core. However, we avoid publishing it via "private": true, so currently people can't use @penrose/core from npm because @penrose/optimizer is missing. This PR attempts to fix that problem by changing @penrose/optimizer to be a dev dependency instead, since we currently just bundle it using esbuild. See also #1173.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated registry diagram changes

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

± Registry diff

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                        0s   1s   2s   3s   4s   5s   6s   7s   8s
                                        |    |    |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra    ▝▀▚▚
allShapes-allShapes                     ▝▀▀▄▚▄▄▖
arrowheads-arrowheads                   ▝▀▚▚
circle-example-euclidean                ▝▀▀▀▀▀▞▀▀▖
collinear-euclidean                     ▝▀▀▀▀▞▖
congruent-triangles-euclidean           ▝▀▀▀▀▀▀▀▀▀▞▖
continuousmap-continuousmap             ▝▀▀▞▖
hypergraph-hypergraph                   ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
incenter-triangle-euclidean             ▝▀▀▀▀▀▞▖
lagrange-bases-lagrange-bases           ▝▀▀▞▖
midsegment-triangles-euclidean          ▝▀▀▀▀▀▚▚
non-convex-non-convex                   ▝▀▀▀▀▀▞▖
one-water-molecule-atoms-and-bonds      ▝▀▞▖
parallel-lines-euclidean                ▝▀▀▀▚▚
persistent-homology-persistent-homology ▝▀▀▀▀▀▀▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▄
points-around-line-shape-distance       ▝▀▀▀▀▀▞▖
points-around-polyline-shape-distance   ▝▀▀▀▀▀▀▀▀▀▀▀▀▚▚
points-around-star-shape-distance       ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▞▖
siggraph-teaser-euclidean-teaser        ▝▀▀▀▀▀▀▞▖
small-graph-disjoint-rect-line-horiz    ▝▀▀▀▀▀▀▀▀▀▀▞▖
small-graph-disjoint-rects              ▝▀▚▚
small-graph-disjoint-rects-large-canvas ▝▀▞▖
small-graph-disjoint-rects-small-canvas ▝▀▀▞▖
tree-tree                               ▝▀▚▄▚
tree-venn                               ▝▀▀▀▀▞▖
tree-venn-3d                            ▝▀▀▀▚▚▄
two-vectors-perp-vectors-dashed         ▝▀▚▚
vector-wedge-exterior-algebra           ▝▀▀▞▖
wet-floor-atoms-and-bonds               ▝▀▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
word-cloud-example-word-cloud           ▝▀▀▀▀▀▚▚
wos-laplace-estimator-walk-on-spheres   ▝▀▀▀▀▀▀▀▀▀▚▚
wos-nested-estimator-walk-on-spheres    ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚▀▀▀▀▀▀▀▖
wos-offcenter-estimator-walk-on-spheres ▝▀▀▀▀▀▀▀▀▀▀▚▚
wos-poisson-estimator-walk-on-spheres   ▝▀▀▀▀▀▀▀▀▀▀▀▀▞▀▚

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3f165fd
Status: ✅  Deploy successful!
Preview URL: https://45492986.penrose-72l.pages.dev
Branch Preview URL: https://optimizer-dependency.penrose-72l.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #1185 (3f165fd) into main (f1249e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1185   +/-   ##
=======================================
  Coverage   62.91%   62.91%           
=======================================
  Files          59       59           
  Lines        7164     7164           
  Branches     1673     1673           
=======================================
  Hits         4507     4507           
  Misses       2572     2572           
  Partials       85       85           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@samestep samestep merged commit c2c020d into main Jan 3, 2023
@samestep samestep deleted the optimizer-dependency branch January 3, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant