Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SVG overflow in Simple component #1321

Merged
merged 3 commits into from
Feb 23, 2023
Merged

fix: SVG overflow in Simple component #1321

merged 3 commits into from
Feb 23, 2023

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Feb 22, 2023

Description

Because the render doesn't set SVG width and height, <Simple> will overflow if the diagram height exceed 90% of the diagram width.

image

Implementation strategy and design decisions

This PR sets the SVG width and height after rendering, thereby scaling the SVG to the parent <div>.

image

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated registry diagram changes

@cloudflare-pages
Copy link

cloudflare-pages bot commented Feb 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 782ffe0
Status: ✅  Deploy successful!
Preview URL: https://7d5ff3bb.penrose-72l.pages.dev
Branch Preview URL: https://fix-grid-overflow.penrose-72l.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

± Registry diff

M	tree-venn-3d.svg

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                                    0s   1s   2s   3s   4s   5s   6s   7s   8s
                                                    |    |    |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra                ▝▚▚
allShapes-allShapes                                 ▝▚▚▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
arrowheads-arrowheads                               ▝▞▖
caffeine-structural-formula                         ▝▀▀▚▀▚
center-shrink-circle-animation                      ▝▞▖
circle-example-euclidean                            ▝▀▚▀▀▀▖
closest-point-test-closest-point                    ▝▀▀▀▀▀▀▀▀▞▖
collinear-euclidean                                 ▝▀▞▖
congruent-triangles-euclidean                       ▝▀▀▚▚
continuousmap-continuousmap                         ▝▚▚
cubic-bezier-cubic-bezier                           ▝▚▀▀▚
glutamine-molecules-basic                           ▝▀▞▖
half-adder-distinctive-shape                        ▝▀▞▚
hypergraph-hypergraph                               ▝▀▀▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
incenter-triangle-euclidean                         ▝▀▚▚
lagrange-bases-lagrange-bases                       ▝▚▚
matrix-matrix-addition-matrix-ops                   ▝▚▚
matrix-matrix-division-elementwise-matrix-ops       ▝▚▚
matrix-matrix-multiplication-elementwise-matrix-ops ▝▚▚
matrix-matrix-multiplication-matrix-ops             ▝▚▚
matrix-matrix-subtraction-matrix-ops                ▝▚▚
matrix-transpose-matrix-ops                         ▝▚▚
matrix-vector-left-multiplication-matrix-ops        ▝▚▚
matrix-vector-right-multiplication-matrix-ops       ▝▚▚
midsegment-triangles-euclidean                      ▝▀▞▖
mobius-mobius                                       ▝▞▖
non-convex-non-convex                               ▝▀▞▖
one-water-molecule-atoms-and-bonds                  ▝▞▖
parallel-lines-euclidean                            ▝▀▞▚
persistent-homology-persistent-homology             ▝▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▄
points-around-line-shape-distance                   ▝▀▚▚
points-around-polyline-shape-distance               ▝▀▀▚▚
points-around-star-shape-distance                   ▝▀▀▀▚▚
quaternion-group-group-theory-cayley-graph          ▝▀▀▞▖
quaternion-group-group-theory-multiplication-table  ▝▀▀▀▄▞▄
scalar-vector-division-matrix-ops                   ▝▚▚
scalar-vector-left-multiplication-matrix-ops        ▝▚▚
scalar-vector-right-multiplication-matrix-ops       ▝▚▚
siggraph-teaser-euclidean-teaser                    ▝▀▚▚
small-graph-disjoint-rect-line-horiz                ▝▀▚▚
small-graph-disjoint-rects                          ▝▞▖
small-graph-disjoint-rects-large-canvas             ▝▚▚
small-graph-disjoint-rects-small-canvas             ▝▞▖
tree-tree                                           ▝▚▚
tree-venn                                           ▝▀▀▞▖
tree-venn-3d                                        ▝▀▚▚▄▖
two-triangles-triangle-mesh-3d                      ▝▚▚
two-vectors-perp-vectors-dashed                     ▝▚▚
vector-vector-addition-matrix-ops                   ▝▚▚
vector-vector-division-elementwise-matrix-ops       ▝▚▚
vector-vector-multiplication-elementwise-matrix-ops ▝▚▚
vector-vector-outerproduct-matrix-ops               ▝▚▚
vector-vector-subtraction-matrix-ops                ▝▚▚
vector-wedge-exterior-algebra                       ▝▚▚
wet-floor-atoms-and-bonds                           ▝▚▀▀▖
word-cloud-example-word-cloud                       ▝▀▚▚
wos-laplace-estimator-walk-on-spheres               ▝▀▀▞▖
wos-nested-estimator-walk-on-spheres                ▝▀▀▚▀▀▀▖
wos-offcenter-estimator-walk-on-spheres             ▝▀▀▞▀▀▀▚
wos-poisson-estimator-walk-on-spheres               ▝▀▚▀▚

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #1321 (782ffe0) into main (9795420) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1321   +/-   ##
=======================================
  Coverage   61.28%   61.28%           
=======================================
  Files          63       63           
  Lines        7829     7829           
  Branches     1845     1845           
=======================================
  Hits         4798     4798           
  Misses       2924     2924           
  Partials      107      107           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wodeni wodeni mentioned this pull request Feb 23, 2023
@wodeni wodeni merged commit df119ac into main Feb 23, 2023
@wodeni wodeni deleted the fix-grid-overflow branch February 23, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant