refactor: restore the 2D triangle mesh domain #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ea93359
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dd092fc9.penrose-72l.pages.dev |
| Branch Preview URL: | https://triangle-mesh.penrose-72l.pages.dev |
Codecov Report
@@ Coverage Diff @@
## main #1354 +/- ##
=======================================
Coverage 62.14% 62.14%
=======================================
Files 67 67
Lines 8557 8557
Branches 2050 2050
=======================================
Hits 5318 5318
Misses 3101 3101
Partials 138 138
|
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. Data |
samestep
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#770 and #808 introduced the 2D triangle mesh domain but never tracked them in the registry. This PR restores this domain by fixing a few minor issues and add diagrams to the registry.
Implementation strategy and design decisions
attrRotationuses the top-left corner as the default rotation origin, which seems wrong. Changed so that the default is the shape's bbox center. Due to this fix, all diagrams that containTextare impacted, since we include therotationtransformation even if the rotation is zero.angle-equivalence. The code remains commented out because it's blocked by Implement Style modules (imports and namespaces) #776, but here's a diagram with the block uncommented.Examples with steps to reproduce them
Checklist
Open questions
Questions that require more discussion or to be addressed in future development: