Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 2d triangle mesh examples #808

Merged
merged 30 commits into from Jan 10, 2022
Merged

feat: 2d triangle mesh examples #808

merged 30 commits into from Jan 10, 2022

Conversation

keenancrane
Copy link
Collaborator

Description

This PR adds additional examples (and features) to the triangle-mesh-2d domain, which mimic several "hand drawn" diagrams from Crane et al. It also adds several features in support of these diagrams, namely:

  • add a rotateBy(vector,angle) function to Style
  • restore the Circle-Line disjoint constraint
  • add a lineLineIntersection function to Style, which computes a line intersection given pairs of points along the two lines
  • add an angleOf(vector) function to Style, which computes the angle with the positive x-axis
  • disable showing the diagram history in the browser-ui (which dramatically speeds up feedback)
  • update vim syntax highlighting

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code follows the style guidelines of this project (e.g.: no ESLint warnings)

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #808 (756ecb0) into main (4a94cac) will decrease coverage by 0.31%.
The diff coverage is 14.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   65.42%   65.10%   -0.32%     
==========================================
  Files          59       59              
  Lines        7979     8022      +43     
  Branches     1410     1415       +5     
==========================================
+ Hits         5220     5223       +3     
- Misses       2750     2790      +40     
  Partials        9        9              
Impacted Files Coverage Δ
packages/core/src/contrib/Functions.ts 32.38% <0.00%> (-1.36%) ⬇️
packages/core/src/contrib/Objectives.ts 50.00% <0.00%> (-0.99%) ⬇️
packages/core/src/contrib/ConstraintsUtils.ts 57.03% <7.14%> (-6.13%) ⬇️
packages/core/src/contrib/Constraints.ts 65.09% <42.85%> (-1.91%) ⬇️
packages/core/src/engine/Autodiff.ts 54.83% <42.85%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a94cac...756ecb0. Read the comment docs.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 756ecb0
Status: ✅  Deploy successful!
Preview URL: https://cba26a0d.penrose-panes.pages.dev

View logs

@keenancrane keenancrane merged commit e407858 into main Jan 10, 2022
@wodeni wodeni deleted the trimesh2d-examples branch May 24, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants