ci: hash all package.json files for dep caching
#1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
a87e29c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://efdd6de2.penrose-72l.pages.dev |
| Branch Preview URL: | https://workspace-packages-wildcard.penrose-72l.pages.dev |
Codecov Report
@@ Coverage Diff @@
## main #1414 +/- ##
=======================================
Coverage 64.77% 64.77%
=======================================
Files 64 64
Lines 7515 7515
Branches 1760 1760
=======================================
Hits 4868 4868
Misses 2521 2521
Partials 126 126 |
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. Data |
wodeni
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #904 I realized that we need to invalidate our CI deps cache anytime we add a package, which I implemented by removing the wildcard from
"packages"inlerna.json, meaning that now anyone adding a package needed to remember to also list it in that file. Then in #1081 I put back the wildcard inlerna.jsonand moved the explicit list to our rootpackage.jsoninstead. But now that #1412 is merged, I realized that we can get rid of this error-prone need to explicitly list ourpackages/by instead just hashing all thepackage.jsonfiles in the repo, which will automatically detect when packages are added, removed, etc. This PR does that, so now adding a package doesn't have any necessary hidden steps beyond creating a new folder underpackages/.Checklist