chore: don't use a multi-root VS Code workspace #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
8c3c16b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://429341aa.penrose-72l.pages.dev |
| Branch Preview URL: | https://no-code-workspace.penrose-72l.pages.dev |
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. Data |
Codecov Report
@@ Coverage Diff @@
## main #1412 +/- ##
=======================================
Coverage 64.77% 64.77%
=======================================
Files 64 64
Lines 7515 7515
Branches 1760 1760
=======================================
Hits 4868 4868
Misses 2521 2521
Partials 126 126 |
wodeni
approved these changes
May 20, 2023
This was referenced May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I created our
penrose.code-workspacefile in #732 because at the time it seemed like we needed to use a multi-root workspace in order to get some TypeScript IDE features to work properly. Having since worked on other Node monorepo projects with single-root workspaces, I no longer believe this is the case, so I'm opening this PR to switch us to the much simpler single-root workspace setup. Seems to work just fine, and much less complex.Checklist