feat: homepage gallery component #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. If a row has only one bar instead of four, that means it's not a trio and the bar just shows the total time spent for that example, again rounded up to the nearest 100ms. Data |
Deploying with
|
| Latest commit: |
9f2a21b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://87129b2c.penrose-72l.pages.dev |
| Branch Preview URL: | https://gallery.penrose-72l.pages.dev |
|
Thanks @wodeni! Is the idea that these examples will show up on the landing page (https://penrose.cs.cmu.edu/)? |
You can preview the landing page here: |
samestep
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1288. Resolves #1307.
This PR adds a new
Gallerycomponent tocomponents, which is used in the "Examples" page on our site. To make this work, I had to fix a SVG andImagerelated issue: #1288. The overall strategy is to runsvgo.optimizewith two plugins (prefixIdsandinlineStyles) at two places:yarn registrytest andeditorSVG download.Implementation strategy and design decisions
inlineStylesfixes this issueImageimport #1288: we are still usingmakeIdsUniqueintroduced in feat: show multiple diagram instances on a grid ineditor#1287 because runningsvgoin real time can be quite slow. InGallery, since we are pulling frommain's cached SVGs, they are already optimized usingprefixIds.Examples with steps to reproduce them
Checklist
Open question
prefixIdsandmakeIdsUniqueconcurrently. This doesn't seem to cause a problem in general, but it's a bit odd.GalleryandExampleBrowserpull SVGs frommain. We should find a way to run the registry and copy the cached SVGs intodocs-sitein another PR.