Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the frame tab to show current state in browser-ui #835

Merged
merged 4 commits into from Jan 13, 2022

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Jan 13, 2022

Description

Related issue/PR: #808

#808 disabled history frames in @penrose/browser-ui for performance reasons. However, it's still useful to see the current State data for debugging. This PR replaced the existing frame selection logic with just the current state and renamed the frame tab to be state in the UI.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings

@wodeni wodeni self-assigned this Jan 13, 2022
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jan 13, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8464659
Status: ✅  Deploy successful!
Preview URL: https://4faf6e68.penrose-panes.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #835 (8464659) into main (a0249f2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   68.05%   68.05%           
=======================================
  Files          61       61           
  Lines        7717     7717           
  Branches     1452     1452           
=======================================
  Hits         5252     5252           
  Misses       2452     2452           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0249f2...8464659. Read the comment docs.

@wodeni wodeni merged commit b985eb4 into main Jan 13, 2022
@wodeni wodeni deleted the state-view branch January 13, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant