Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Strengthen length check in zip3 #915

Merged
merged 1 commit into from Mar 18, 2022
Merged

fix: Strengthen length check in zip3 #915

merged 1 commit into from Mar 18, 2022

Conversation

samestep
Copy link
Collaborator

This was originally added in #817 but for some reason I didn't realize that the length check condition is completely wrong.

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #915 (d666a60) into main (ffd63d0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #915   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files          62       62           
  Lines        8117     8117           
  Branches     1768     1768           
=======================================
  Hits         5534     5534           
  Misses       2576     2576           
  Partials        7        7           
Impacted Files Coverage Δ
packages/core/src/utils/Util.ts 59.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd63d0...d666a60. Read the comment docs.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d666a60
Status: ✅  Deploy successful!
Preview URL: https://0b9fe2d8.penrose-panes.pages.dev

View logs

@samestep samestep merged commit 36c0867 into main Mar 18, 2022
@samestep samestep deleted the zip3-check-fix branch March 18, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant