-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Clean up the Style compiler #817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Codecov Report
@@ Coverage Diff @@
## main #817 +/- ##
==========================================
+ Coverage 67.81% 67.86% +0.05%
==========================================
Files 61 61
Lines 7643 7640 -3
Branches 1378 1375 -3
==========================================
+ Hits 5183 5185 +2
+ Misses 2451 2445 -6
- Partials 9 10 +1
Continue to review full report at Codecov.
|
samestep
changed the title
refactor: Improve Style compiler
refactor: Clean up the Style compiler
Jan 12, 2022
wodeni
approved these changes
Jan 12, 2022
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up
compiler/Style
:nameAnonBlock
linear timethrow
s viaswitch
instead ofif
/else
, and also better typingzip2
andzip3
utils to replace poorly-typed usages of_.zip
findSubstsProg
Checklist
Open questions
concat
)