Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Disallow eslint-disable comments in core #965

Merged
merged 1 commit into from
May 13, 2022

Conversation

samestep
Copy link
Collaborator

Description

This PR uses eslint-plugin-eslint-comments to disallow eslint-disable comments in @penrose/core. Many of the ones we already had were added by me in #817, and a couple by @wodeni in #829, but some of them were simply outdated.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated changes to the diagrams/ folder

@samestep samestep requested a review from wodeni May 13, 2022 00:53
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #965 (5cac881) into main (a7811dd) will decrease coverage by 0.00%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   63.10%   63.09%   -0.01%     
==========================================
  Files          62       62              
  Lines        7925     7924       -1     
  Branches     1842     1841       -1     
==========================================
- Hits         5001     5000       -1     
  Misses       2800     2800              
  Partials      124      124              
Impacted Files Coverage Δ
packages/core/src/compiler/Style.ts 78.83% <ø> (ø)
packages/core/src/contrib/Functions.ts 13.71% <ø> (ø)
packages/core/src/parser/ParserUtil.ts 97.01% <ø> (ø)
packages/core/src/utils/CollectLabels.ts 65.97% <40.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7811dd...5cac881. Read the comment docs.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5cac881
Status: ✅  Deploy successful!
Preview URL: https://3239fcef.penrose-panes.pages.dev

View logs

@samestep samestep changed the title test: Disallow eslint-disable comments in core lint: Disallow eslint-disable comments in core May 13, 2022
@samestep samestep changed the title lint: Disallow eslint-disable comments in core test: Disallow eslint-disable comments in core May 13, 2022
@samestep samestep requested a review from cmumatt May 13, 2022 15:09
Copy link
Contributor

@cmumatt cmumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this!

@samestep samestep merged commit 395e776 into main May 13, 2022
@samestep samestep deleted the disallow-eslint-disable branch May 13, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants