Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDI-17517] - Inconsistent Time zone during scheduling job/transforma… #4268

Merged
merged 1 commit into from Oct 18, 2018

Conversation

cravobranco
Copy link
Contributor

…tion when server and client in different time zones

  • Added some implementation also for the "Update Job" use-case.

@pamval , @pentaho-lmartins , @mbatchelor
Note: All unit tests were already added in the previous PR (#4233) and are related to the new introduced method setTimezone(..).

…tion when server and client in different time zones

* Added some implementation also for the "Update Job" use-case.
@wingman-pentaho
Copy link
Collaborator

Build Completed

🔥 This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

mvn -B -f 'pom.xml' -pl 'scheduler' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands

mvn -B -f 'pom.xml' -pl 'scheduler' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files

  scheduler/src/main/java/org/pentaho/platform/scheduler2/quartz/QuartzScheduler.java

Unit Test Coverage

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

⚠️ Coverage Changes (click to expand)
org.pentaho.platform.config.MondrianConfigProperties
  • Branch Change: -7.1% 🔻
  • Instruction Change: -3.2% 🔻
org.pentaho.platform.scheduler2.quartz.QuartzScheduler
  • Branch Change: -0.7% 🔻
  • Complexity Change: -0.3% 🔻
  • Instruction Change: -0.2% 🔻
  • Line Change: -0.2% 🔻

@sailingscally sailingscally merged commit a73d77b into pentaho:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants