WIP: Implement ABCI++ #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These could be re-enabled later, but they don't compile on master and I need a clean test suite to be able to catch regressions from updating proto definitions.
These types mirror the generated types in tendermint_proto, but have better naming. The documentation is filled in from the ABCI methods & types documentation.
This conflicts with the existing Event type, so wait to replace it until that type's usages are cleaned up.
A-Manning
force-pushed
the
ash/abci++862protobuf
branch
from
de6e4f3
to
e235296
Compare
|
Hey, sorry for the delay in getting to this. I think the thing that makes the most sense to do is to:
There's been a bit of a delay getting the PR upstream because of some people being offline, but I talked with @thanethomson today about getting it merged, so hopefully I'll be able to get some movement on it soon. |
5 tasks
hdevalence
force-pushed
the
abci-domain-types
branch
2 times, most recently
from
e6d14ac
to
36069f3
Compare
hdevalence
force-pushed
the
abci-domain-types
branch
from
36069f3
to
2a78e5f
Compare
hdevalence
force-pushed
the
abci-domain-types
branch
6 times, most recently
from
45c3946
to
00f7918
Compare
hdevalence
force-pushed
the
abci-domain-types
branch
from
00f7918
to
9cb2b06
Compare
hdevalence
force-pushed
the
abci-domain-types
branch
from
9cb2b06
to
4bf310b
Compare
hdevalence
force-pushed
the
abci-domain-types
branch
from
fde6080
to
9660feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the API changes for ABCI++.