Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments link to non-existing repository #29

Closed
jasiekmarc opened this issue Mar 24, 2017 · 4 comments
Closed

Comments link to non-existing repository #29

jasiekmarc opened this issue Mar 24, 2017 · 4 comments

Comments

@jasiekmarc
Copy link

We have a team (private) repository owned by the team's leader, and a bunch of Github users having access to it and proposing Pull Requests. In the comment, @pep8speaks links to the changed files and lines having errors. Unfortunately, the link (generated here: https://github.com/OrkoHunter/pep8speaks/blob/master/pep8speaks/helpers.py#L217) points to the PR authors' non-existing repositories rather than the team's repository.

@OrkoHunter
Copy link
Collaborator

@jasiekmarc I believe the bot runs on the branch of the author of the PR. So, if the branch is on the fork of the user, it would like over there. I did not get the part when you say that the author's repository does not exist. How does he create a Pull Request then? Is it created from the same repository with a different branch?

@jasiekmarc
Copy link
Author

Exactly. We just create branches in the original repository, and them merge them to master.

@OrkoHunter
Copy link
Collaborator

Okay thanks. I'll take a look in the github payload and modify which url to use. If you have the fix, it'd be great if you could submit a PR.

@OrkoHunter
Copy link
Collaborator

Closing this issue. Please re-open if the error still persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants