Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the configuration file form PR branch #55

Closed
rlaverde opened this issue Aug 14, 2017 · 3 comments
Closed

Read the configuration file form PR branch #55

rlaverde opened this issue Aug 14, 2017 · 3 comments

Comments

@rlaverde
Copy link

rlaverde commented Aug 14, 2017

Reading the .pep8speaks.yaml file from PR branch instead of base branch, will make easy to test changes in the config file.

@OrkoHunter
Copy link
Collaborator

OrkoHunter commented Aug 15, 2017

Hello @rlaverde

Thanks for opening an issue about it. The default behavior for reading the config file was to read it from the PR branch (like Travis, and others) itself. It was working fine, when suggestions brought up some issues -

  1. If there were multiple Pull Requests pending, all of them had to be rebased, just to ignore some errors.
  2. Same goes for a change every time. Changing it on the main repo will instantly reflect on old/new PRs.

Hence, a month ago the behavior was changed.

@rlaverde
Copy link
Author

I understood, maybe the PR branch could be a fallback if the there isn't a config file in the main branch. Or maybe and option mentioning the bot, i. e. "@pep8speaks read config from PR branch".

@OrkoHunter
Copy link
Collaborator

Thank you @rlaverde for your suggestion! PEP8Speaks will now look at the branch of Pull Request as a fallback if no config is found on the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants