v0.13.0 #72
v0.13.0 #72
Conversation
| def _custom_repr(obj, prefix=""): | ||
| """ | ||
| Calls the ordinary repr on every object but list, which is | ||
| converted to a block style string instead. |
There was a problem hiding this comment.
by block style string I mean:
"""
- item
- item1
- item2
"""
as opposed to flow style:
"[item, item1, item2]"
That's what this PR is all about :)
feel free to change/suggest other nomenclature
There was a problem hiding this comment.
Ah no I didn't mean to suggest it should change, I just really hadn't heard it, but it totally makes sense now seeing it.
There was a problem hiding this comment.
do you want to do anything differently if there are a ton of items in the list?
There was a problem hiding this comment.
do you mean using flow or block style depending on the number of items in the list? I'd personally prefer to stick to one or the other.
There was a problem hiding this comment.
not necessarily. I was just worried at this getting huge for a large object, that's all.
There was a problem hiding this comment.
maybe it would only display the first 10 components, for example
| @@ -66,15 +65,29 @@ def __repr__(self): | |||
| self._data_for_repr(), self._new_empty_basic_map)) | |||
|
|
|||
| def _render(self, data, exclude_class_list=[]): | |||
| def _custom_repr(obj, prefix=""): | |||
There was a problem hiding this comment.
Nice, bet this will look much better
| @@ -3,6 +3,7 @@ python: | |||
| - "2.7" | |||
| - "3.5" | |||
| - "3.6" | |||
| - "3.7" | |||
| @@ -54,7 +54,7 @@ def read_reqs(reqs_name): | |||
| ], | |||
| keywords="dict, map, mapping, dot, item, getitem, attr, getattr, key-value, dynamic, mutable, access", | |||
| url="https://github.com/pepkit/{}/".format(PACKAGE), | |||
| author=u"Nathan Sheffield, Vince Reuter", | |||
| author=u"Nathan Sheffield, Vince Reuter, Michal Stolarczyk", | |||
|
I left a couple small suggestions but looks good! |
nested expansion; #74
| @@ -1,6 +1,6 @@ | |||
| hypothesis | |||
| hypothesis==4.38.0 | |||
There was a problem hiding this comment.
do you need to pin this to a specific version?
|
excited to have the released version of attmap passing CI again! |
fix databio/yacman#40
to do: