Skip to content

Commit

Permalink
potential fix pepkit/peppy#459
Browse files Browse the repository at this point in the history
  • Loading branch information
donaldcampbelljr committed Dec 18, 2023
1 parent 37dacb0 commit 281cef4
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions looper/project.py
Original file line number Diff line number Diff line change
Expand Up @@ -725,6 +725,8 @@ def _samples_by_piface(self, piface_key):
else:
samples_by_piface.setdefault(source, set())
samples_by_piface[source].add(sample[self.sample_table_index])
sample.sample_name = sample[self.sample_table_index]

for msg in msgs:
_LOGGER.warning(msg)
return samples_by_piface
Expand Down

2 comments on commit 281cef4

@nsheff
Copy link
Contributor

@nsheff nsheff commented on 281cef4 Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see 2 problems with this:

  1. can this fail if there's no sample_table_index?
  2. more importantly -- ideally, we don't want to force sample_name...we want to use the proper index specified by the user, right?

@donaldcampbelljr
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. it does not fail if there is no sample_table_index
  2. Yes this makes sense.

Please sign in to comment.