Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looper - pephub is broken #453

Closed
nsheff opened this issue Feb 13, 2024 · 4 comments
Closed

Looper - pephub is broken #453

nsheff opened this issue Feb 13, 2024 · 4 comments
Assignees
Labels

Comments

@nsheff
Copy link
Contributor

nsheff commented Feb 13, 2024

When I run the hello world example on how to use looper with PEPhub, I get this error:

looper run
Looper version: 1.7.0
Command: run
Using looper config (.looper.yaml).
Traceback (most recent call last):
  File "/home/nsheff/.local/bin/looper", line 8, in <module>
    sys.exit(main())
  File "/home/nsheff/.local/lib/python3.8/site-packages/looper/cli_looper.py", line 684, in main
    project_dict=PEPHubClient()._load_raw_pep(
  File "/home/nsheff/.local/lib/python3.8/site-packages/pephubclient/pephubclient.py", line 345, in _load_raw_pep
    correct_proj_dict = ProjectDict(**json.loads(decoded_response))
  File "/usr/lib/python3.8/json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.8/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.8/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
@nsheff nsheff added the bug label Feb 13, 2024
@nsheff
Copy link
Contributor Author

nsheff commented Feb 13, 2024

I am wondering if this is related to:

  • change in the API URL

Either way, we need to

  1. fix the problem
  2. make this error message more clear about what is happening, in case this happens again in the future. As in, if it's something like the server is not working, it should say "couldn't connect to the server" or if the API appears to no longer be compatible, it could say "couldn't get record from PEPhub API at URL: https://xyz... "

@khoroshevskyi
Copy link
Member

I think this issue is outdated, you should use pephubclient version >0.3.0

@nsheff
Copy link
Contributor Author

nsheff commented Feb 13, 2024

updating to pephubclient 0.4.0 and the error went away. thanks.

@nsheff nsheff closed this as completed Feb 13, 2024
@nsheff
Copy link
Contributor Author

nsheff commented Feb 13, 2024

probably should change this:

pephubclient>=0.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants