Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipestat compatibility and move table function to pipestat #409

Merged
merged 21 commits into from
Aug 25, 2023

Conversation

donaldcampbelljr
Copy link
Contributor

This PR addresses: #390

It aligns looper compatibility with pipestat 0.5.0 and greater as well as migrating looper table to pipestat.table.

It removes unused htmlreporting code as well as TableOld, ReportOld, CheckOld, requiring the user to properly configure pipestat if they wish to use these functions.

@donaldcampbelljr donaldcampbelljr marked this pull request as ready for review August 21, 2023 19:27
@donaldcampbelljr
Copy link
Contributor Author

This requires dev branches of eido (0.2.2.dev0), yacman (0.9.2.dev1) and Peppy (0.40.0a3) to pass tests locally.

looper/project.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@donaldcampbelljr
Copy link
Contributor Author

donaldcampbelljr commented Aug 23, 2023

  • Per discussion, change how looper determines pipestat configuration, i.e. instead of relying on pipestat's config file, the looper config file should supply the proper information to use pipestat. #

@donaldcampbelljr
Copy link
Contributor Author

Passing tests locally except for:

FAILED tests/smoketests/test_run.py::TestLooperConfig::test_init_config_file[run] - Failed: DID RAISE: 'Namespace' object has no attribute 'config_file'
FAILED tests/smoketests/test_run.py::TestLooperConfig::test_init_config_file[runp] - Failed: DID RAISE: 'Namespace' object has no attribute 'config_file'

These failing tests were pulled in from Dev so I believe its not related to this PR's code changes.

@donaldcampbelljr donaldcampbelljr merged commit 8703d23 into dev Aug 25, 2023
1 of 3 checks passed
@donaldcampbelljr donaldcampbelljr deleted the pipestat_polish branch August 25, 2023 17:04
@donaldcampbelljr donaldcampbelljr restored the pipestat_polish branch August 25, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants