Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt yacman v0.9.3 #147

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Adapt yacman v0.9.3 #147

merged 7 commits into from
Feb 7, 2024

Conversation

nsheff
Copy link
Contributor

@nsheff nsheff commented Feb 1, 2024

Draft PR of changes to make pipestat compatible with yacman v0.9.3, in prep for yacman v1

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6c4797c) 54.51% compared to head (dc47361) 54.56%.

Files Patch % Lines
pipestat/pipestat.py 71.42% 2 Missing ⚠️
pipestat/backends/file_backend/filebackend.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #147      +/-   ##
==========================================
+ Coverage   54.51%   54.56%   +0.05%     
==========================================
  Files          15       15              
  Lines        2328     2335       +7     
==========================================
+ Hits         1269     1274       +5     
- Misses       1059     1061       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsheff nsheff changed the title Yacman1 Adapt yacman v0.9.3 Feb 1, 2024
@donaldcampbelljr
Copy link
Contributor

donaldcampbelljr commented Feb 7, 2024

Ok, I think I've got this completed. One thing is that the new functionality is a bit messier to implement:

        self.cfg[CONFIG_KEY] = YAMLConfigManager(
            entries=config_dict, filepath=self.cfg["config_path"]
        )

becomes

        if config_dict is not None:
            self.cfg[CONFIG_KEY] = YAMLConfigManager.from_obj(entries=config_dict)
        elif self.cfg["config_path"] is not None:
            self.cfg[CONFIG_KEY] = YAMLConfigManager.from_yaml_file(filepath=self.cfg["config_path"])
        else:
            self.cfg[CONFIG_KEY] = YAMLConfigManager()

@donaldcampbelljr donaldcampbelljr marked this pull request as ready for review February 7, 2024 19:18
@donaldcampbelljr donaldcampbelljr merged commit 6823715 into dev Feb 7, 2024
5 checks passed
@donaldcampbelljr donaldcampbelljr deleted the yacman1 branch February 7, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants